Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #99
About
This pull request makes several improvements to the Python client for Project AirSim, focusing on dependency management, error handling, documentation clarity, and the robustness of the LiDAR display utility. The most important changes are grouped below by theme.
Dependency and environment updates:
open3ddependency version inpyproject.tomlto allow versions newer than 0.16.0, improving compatibility and flexibility.docs/client_setup.mdto clarify that Python 3.7 or newer is supported, and simplified environment setup instructions for both Windows and Linux. [1] [2] [3]LiDAR display utility improvements:
ArgumentErrorwith standardValueErrorexceptions inlidar_utils.pyfor more conventional Python error handling. [1] [2] [3]display_loopinlidar_utils.pyto check if the Open3D window is still open, properly destroy the window when done, and cap the frame rate to reduce CPU usage and avoid platform-specific issues.SetViewBoundsRequestclass to accept and storeview_boundsupon initialization, enabling more flexible view management.How Has This Been Tested?
Screenshots and videos (if appropriate):